Refactor with PlutoDevMacros 0.6.0 #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 87.37% 81.66% -5.72%
==========================================
Files 11 12 +1
Lines 206 240 +34
==========================================
+ Hits 180 196 +16
- Misses 26 44 +18
☔ View full report in Codecov by Sentry. |
|
Closing this as the current way forward is to separate the JS part into a separate JS library (see #50) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a significant internal refactor of the code in order to leverage the new script/html combining functionality from PlutoDevMacros v0.6
It is now easier to specify how to render PlutoPlot objects both inside and outside Pluto, opening the possibility of also rendering the plots correctly when not using Pluto.
The plot will in principle render automatically in the correct way depending on whether it's shown inside or outside Pluto.
PlutoPlot objects are now also rendered in the Plot pane in VSCode while still providing most of the functionality of PlutoPlotly that are not in PlotlyBase (like easily adding JS code or listeners).
With this rewrite, it is now easy to directly print a fully standalone hml document that contains the plot using the
print_htmlfunction defined in PlutoDevMacros and extended here for PlutoPlot objects. This will fix #12